feat: use custom intro/outro playlists per show #2941
+2,276
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remark: this was an absolute nightmare to implent through all layers and abstractions. I full heartedly support ditching the legacy UI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 70.36% 70.46% +0.09%
==========================================
Files 149 149
Lines 4033 4029 -4
==========================================
+ Hits 2838 2839 +1
+ Misses 1195 1190 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
caveman99
force-pushed
the
custom-auto-playlist
branch
2 times, most recently
from
0495f7b
to
a62f74d
Compare
jooola
reviewed
Feb 18, 2024
jooola
reviewed
Feb 18, 2024
jooola
reviewed
Feb 18, 2024
jooola
reviewed
Feb 18, 2024
jooola
changed the title
caveman99
force-pushed
the
custom-auto-playlist
branch
2 times, most recently
from
5e1fb08
to
743d143
Compare
caveman99
force-pushed
the
custom-auto-playlist
branch
from
7dc68b6
to
c1fc5dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having a global intro and outro playlist in settings is not very flexible for special programming. This adds an override intro/outro playlist per show. If it is not set, the global one is used. also it's ignored if there's no autloading at all.
I have updated the documentation to reflect these changes:
...not yet, but i will.
Testing Notes
What I did:
Schedule 2 shows, one without defining custom lists, one with defining custom lists. one hour before the show starts it should be populated correctly. If you define a global list it shojuld be replaced with the per-show list.