New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playout): add Liquidsoap 2.0 support #2786
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2786 +/- ##
==========================================
- Coverage 70.16% 70.11% -0.06%
==========================================
Files 147 147
Lines 3999 3992 -7
==========================================
- Hits 2806 2799 -7
Misses 1193 1193
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b50a76b
to
cd961e2
Compare
Thanks for your work and I hope to have a look through it later today! Please keep the 2 features (PHP updates and Liquidsoap) in separate PRs - this helps with review and understanding changes later on, generating changelogs, etc. If you wish to test both sets of changes combined, you can have your second branch be branched off the first and note that the first PR needs to be merged first. |
cd961e2
to
23f8200
Compare
23f8200
to
d672f84
Compare
d672f84
to
2c27617
Compare
Description
add Liquidsoap2.0 files
(port syntax 1.4 to 2.0)
Testing Notes
I ran libretime on ubuntu 22.04 and liquidsoap2.0
this pr is just the beginning, just 2 files added it's a clean one...
in order to work under 22.04,it requires changes in
It will require testing changes against ubuntu 20.4 and debian,that's why i think a testing branch can be wise