New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move authentification to the django api #2572
base: main
Are you sure you want to change the base?
Conversation
This PR is still a WIP, but I'd be happy to have feedback whether this looks like a good idea. I didn't get answers on #1788, so I thought I implement a POC, and show how easy (understand not dirty) this could be solved. |
bce42d2
to
fd330d7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
==========================================
+ Coverage 70.30% 71.30% +1.00%
==========================================
Files 148 153 +5
Lines 4024 4280 +256
==========================================
+ Hits 2829 3052 +223
- Misses 1195 1228 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Fixes #1788
Depends on #2523
Moves the authentication mechanism to the API.
PHPSESSID
/api/v2/auth/login
with thePHPSESSID
and a JSON body with the credentialsPHPSESSID
as cookie