New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hls output stream #2234
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
+ Coverage 69.96% 70.03% +0.06%
==========================================
Files 147 147
Lines 3972 3981 +9
==========================================
+ Hits 2779 2788 +9
Misses 1193 1193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This POC is working with docker-compose, really cool to have HLS ! But I think we should rewrite the liquidsoap script before further additions |
742866a
to
2d5406e
Compare
2d5406e
to
bdfa6fe
Compare
bdfa6fe
to
8efbe16
Compare
The HLS setup will add more coupling between nginx and playout, which isn't necessarily a problem, but might require more CLI knowledge for those who want to change some path configuration for example. Maybe we should only install a hls setup behind a experimental feature flag until we iron out the way we want to install, manage it. This will also allow us to experiment with HLS before having to expose it on the libretime interface. |
4fe3273
to
62db5cb
Compare
Hiding this behind a feature-flag is a good idea. Having some sort of feature-flag framework for experimental features in general may be something that we should look into |
62db5cb
to
7065884
Compare
7065884
to
12a0fc2
Compare
No description provided.