Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hls output stream #2234

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Oct 12, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #2234 (12a0fc2) into main (bcddc90) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2234      +/-   ##
==========================================
+ Coverage   69.96%   70.03%   +0.06%     
==========================================
  Files         147      147              
  Lines        3972     3981       +9     
==========================================
+ Hits         2779     2788       +9     
  Misses       1193     1193              
Flag Coverage Δ
analyzer 46.91% <ø> (ø)
api 93.68% <ø> (ø)
api-client 64.40% <ø> (ø)
shared 88.68% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
playout/libretime_playout/liquidsoap/entrypoint.py 100.00% <ø> (ø)
shared/libretime_shared/config/_models.py 96.34% <100.00%> (+0.21%) ⬆️

@jooola
Copy link
Contributor Author

jooola commented Oct 12, 2022

This POC is working with docker-compose, really cool to have HLS ! But I think we should rewrite the liquidsoap script before further additions

@jooola
Copy link
Contributor Author

jooola commented Apr 3, 2023

The HLS setup will add more coupling between nginx and playout, which isn't necessarily a problem, but might require more CLI knowledge for those who want to change some path configuration for example.

Maybe we should only install a hls setup behind a experimental feature flag until we iron out the way we want to install, manage it.

This will also allow us to experiment with HLS before having to expose it on the libretime interface.

@jooola jooola force-pushed the wip/liquidsoap_hls branch 2 times, most recently from 4fe3273 to 62db5cb Compare April 12, 2023 16:08
@paddatrapper
Copy link
Contributor

Hiding this behind a feature-flag is a good idea. Having some sort of feature-flag framework for experimental features in general may be something that we should look into

@jooola jooola modified the milestones: 3.1.0, 3.2.0 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants