New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add e2e tests using cypress #1896
base: main
Are you sure you want to change the base?
Conversation
Maybe I should move thoses files to |
This is great. How does Cypress compare to Selenium? |
Cypress is way easier to use. From what I read in the selenium tests you have a lot of waiting code while you don't need it in cypress. If you have experience with Selenium, I suggest you to write a test and you will see how easy it is ! |
bd535b6
to
0f3b6f8
Compare
This is blocked because we need a way to run a libretime inside the CI, and this is only doable with the docker setup. Once we can run LibreTime inside the CI, we can start implementing more tests for the legacy app. |
c7353da
to
bf78edb
Compare
Codecov Report
@@ Coverage Diff @@
## main #1896 +/- ##
===========================================
- Coverage 69.96% 58.64% -11.33%
===========================================
Files 147 186 +39
Lines 3972 4686 +714
===========================================
- Hits 2779 2748 -31
- Misses 1193 1938 +745
Flags with carried forward coverage won't be shown. Click here to find out more. |
aa62d42
to
926f1af
Compare
Cool, so I have some basic e2e tests running in CI, and it is working nicely ! We currently only test the main branch, meaning that the pull requests only trigger the CI e2e tests if the tests files are changed, not the application code. I am not sure if we want to test pull requests with the e2e tests. It will take ages every time to first build the containers, save the artifacts, pull them in another workflow and run them. Maybe we should improve the container workflow first and see if we can export the build images for reusing them for e2e and other advanced tests. |
Yeah I think we can test PRs at a later stage once we've improved that workflow a bit |
d0459d6
to
0c1025c
Compare
7ee1197
to
5c2f1d2
Compare
This allow us to write e2e tests for the current legacy project. The future web app should have those tests embed inside the webapp project.
We previously were running the tests by hand on the vagrant install, we should write them to cypress tests and automate the testing process.
How this works:
vagrant up bullseye
cd e2e && yarn
yarn start