Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #1270

Merged
merged 2 commits into from
May 11, 2024
Merged

Fix clippy warnings #1270

merged 2 commits into from
May 11, 2024

Conversation

yubiuser
Copy link
Contributor

@yubiuser yubiuser commented Mar 31, 2024

Fixes a clippy warning that occured in recent tests regarding map_clone (https://rust-lang.github.io/rust-clippy/master/index.html#/map_clone) and file creation without explicite defining truncation behavior (https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_open_options)

@yubiuser yubiuser changed the title Update rust to 1.71 in devcontainer and fix map_clone Fix clippy warnings Mar 31, 2024
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Contributor Author

The last commit addressed changes in the beta toolchain that are a consequence of the expansion of redundant import checking. I removed the duplicate imports, another way would be to disable the warning.
There is some discussion ongoing regarding the change:
rust-lang/rust#121315
rust-lang/rust#121708

@roderickvd
Copy link
Member

Thanks a lot for this, great to have the build pass again!

@roderickvd roderickvd merged commit a5964c2 into librespot-org:dev May 11, 2024
9 checks passed
@yubiuser yubiuser deleted the fix/clippy branch May 11, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants