Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add TLS1.3 #493

Closed
wants to merge 1 commit into from
Closed

add TLS1.3 #493

wants to merge 1 commit into from

Conversation

inceabdullah
Copy link

Start on the port 443 with TLS1.3

docker run -it --rm -v$PWD/cert/cert.pem:/etc/ssl/certs/cert.pem -v$PWD/cert/key.pem:/etc/ssl/private/key.pem -p443:443 speedtest

Quentame
Quentame suggested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many comments left

@sstidl
Copy link
Collaborator

sstidl commented Nov 3, 2023

it's not good practice to pack TLS into a micro-service like this. when using docker, you will also have a rev-proxy/load balancer doing the TLS lifting.

@sstidl sstidl added the wontfix label Nov 4, 2023
@sstidl sstidl closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentame Quentame Quentame requested changes

Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inceabdullah @sstidl @Quentame