Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: using <button> instead of <div> #410

Closed
wants to merge 1 commit into from
Closed

Accessibility: using <button> instead of <div> #410

wants to merge 1 commit into from

Conversation

denilsonsa
Copy link

Closes #373

(Sidenote: it was quite annoying to manually re-apply the same patch on 7 files.)

@banaanihillo
Copy link

Taking quite a bit of time to review, eh?

Quentame
Quentame approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sstidl sstidl changed the base branch from master to dev November 4, 2023 14:34
@sstidl sstidl self-assigned this Nov 4, 2023
@sstidl sstidl deleted the branch librespeed:dev May 18, 2024 19:51
@sstidl sstidl closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentame Quentame Quentame approved these changes

Assignees

@sstidl sstidl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility: the "start/abort" button should actually be a button and not a div
4 participants
@denilsonsa @banaanihillo @Quentame @sstidl