Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default settings file, and ignore used file #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dubz
Copy link

@Dubz Dubz commented Sep 26, 2019

This changes the settings file name, and adds an entry to gitignore to ignore the used file name.

This will avoid any issues pulling updates to a live environment with a modified settings file.

This changes the settings file name, and adds an entry to gitignore to ignore the used file name.

This will avoid any issues pulling updates to a live environment with a modified settings file.
@adolfintel
Copy link
Member

That's actually not a bad idea. I'll merge this with the next major release (I need to update the video tutorial)

@Dubz
Copy link
Author

Dubz commented Sep 26, 2019

That's actually not a bad idea. I'll merge this with the next major release (I need to update the video tutorial)

Sounds good!

You may want to consider merging the ./backend/getIP_ipInfo_apikey.php file with it as well, and any other similar files. I'm sure people run into the same issue if they utilize that too.

@adolfintel
Copy link
Member

Yes, I was thinking the same thing

@flying-sausages
Copy link

Seeing as there are conflicts here, has this been merged?

@adolfintel
Copy link
Member

@flying-sausages No, but this concept will certainly be included in the next release. I was planning it for 2020 but I've had too many things to do so I haven't done any real work on LS in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants