Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix systemd graphs using wrong rrd filename variable #15988

Merged
merged 1 commit into from Apr 27, 2024

Conversation

sarabveer
Copy link
Contributor

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2024

CLA assistant check
All committers have signed the CLA.

@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/issue-with-systemd-graph-showing-no-data-file/24156/2

@sarabveer
Copy link
Contributor Author

sarabveer commented Apr 27, 2024

Broken with this commit: 0998592#diff-8b768feed8fa315efa39e9aa7f7d26064b7ab31a397e30e736dc592ce0a5b8f8

Variable name was changed, but the if statement not updated.

@bnerickson
Copy link
Contributor

lgtm

@Jellyfrog Jellyfrog merged commit b14a86e into librenms:master Apr 27, 2024
9 checks passed
@sarabveer sarabveer deleted the fix_systemd_graph branch May 1, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants