Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FibroLAN devices #15967

Merged
merged 4 commits into from May 8, 2024
Merged

Added FibroLAN devices #15967

merged 4 commits into from May 8, 2024

Conversation

Jarod2801
Copy link
Contributor

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog Jellyfrog added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Apr 23, 2024
Copy link

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@Jarod2801
Copy link
Contributor Author

Hm, stills fails.
Looks like because of a bad character of the SysDesc.
The manufacturer uses the character "µ", which causes the error.
LibreNMS displays it as a "?".
Is there a way to replace such charcters?

@murrant
Copy link
Member

murrant commented May 1, 2024

This is actually net-snmp outputting the binary character.

LibreNMS has a function called StringHelpers::inferEncoding() but currently it is not called for sysDescr. Adding that to wherever sysDescr is fetched, might fix the broken encoding.

@Jarod2801
Copy link
Contributor Author

This is actually net-snmp outputting the binary character.

LibreNMS has a function called StringHelpers::inferEncoding() but currently it is not called for sysDescr. Adding that to wherever sysDescr is fetched, might fix the broken encoding.

OK.
But sysDescr isn't fetched explicit. I think it comes per default when fetching the basic device information.
Any way to fetich it "manually" in the yaml file.

Or are there changes needed "deeper" in the code to resolve the problem?

@Jarod2801
Copy link
Contributor Author

Removed the "faulty device" for now, as we need the features on the other devices. Will have a look on the character issue later.

@murrant murrant merged commit 9ee7139 into librenms:master May 8, 2024
8 checks passed
@murrant murrant removed the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants