Mysql PDO options to support SSL/TLS client communication #15832
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Key. This allows for TLS client communication.
Jellyfrog
reviewed
Feb 16, 2024
config/database.php
Outdated
| @@ -66,9 +66,12 @@ | |||
| 'strict' => true, | |||
| 'engine' => null, | |||
| 'sslmode' => env('DB_SSLMODE', 'disabled'), | |||
| 'options' => extension_loaded('pdo_mysql') ? array_filter([ | |||
| 'options' => extension_loaded('pdo_mysql') ? [ | |||
| PDO::MYSQL_ATTR_SSL_VERIFY_SERVER_CERT => false, | |||
There was a problem hiding this comment.
we do not want to force this.
There was a problem hiding this comment.
Apologies, this took some effort to fix. I believe from y testing the latest commit will allows people to use SSL/TLS connections or not. I have tested this on my local development system where I do not SSL/TLS database end; and on a system where I do have SSL/TLS database backend.
SSL/TLS CA, CERT, and KEY are optional. If they are not provided the function array_filter() will remove them.
MYSQL_ATTR_SSL_VERIFY_SERVER_CERT is outside array_filter() because the function will remove the option if it is falsey; however there are times when that variable/setting must be set to false.
…ptional. SSL/TLS CA, CERT, and KEY are optional. If they are not provided the array_filter() will remove them. MYSQL_ATTR_SSL_VERIFY_SERVER_CERT is outside array_filter() because the function will remove the option if it is falsey; however there are times when that variable must be set to false.
murrant
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed mysql connection to include additional options for SSL Cert and Key. This allows for TLS client communication.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.