Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powervault ME Sensors #15814

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

TheMysteriousX
Copy link
Contributor

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja
Copy link
Contributor

Hi @TheMysteriousX
For all polling PHP code, you need to ensure that your are only changing the OIDs that your are expecting to change. If not, your code will apply for each and every OIDs that are currently polled. or will later be added.
Thx

@PipoCanaja PipoCanaja closed this Feb 10, 2024
@PipoCanaja PipoCanaja reopened this Feb 10, 2024
@PipoCanaja PipoCanaja added the Device 🖥️ New or added device support label Feb 10, 2024
@Jellyfrog
Copy link
Member

Any reason this can't be done in yaml?

@TheMysteriousX
Copy link
Contributor Author

You have to know in advance what type of sensor is at an OID to use YAML. The sensors presented are not tabulated - you have to poll it, then parse it to see what type of sensor you got.

@TheMysteriousX
Copy link
Contributor Author

This is good to go, thought there was an issue with discovery but it's down to a database column being too small.
I'll address that seperately.

The example this was duplicated from will be fixed in another PR
Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% sure this can be in yaml.
You use skip_values to reject everything not of the type for that sensor.

@TheMysteriousX
Copy link
Contributor Author

I'm going to need an example because I've found no documented way to parse descriptions with YAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants