New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinera Groove: Add cardAdminStatus states #15782
base: master
Are you sure you want to change the base?
Infinera Groove: Add cardAdminStatus states #15782
Conversation
@@ -0,0 +1 @@ | |||
null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look correct :)
hey @nickhilliard thanks for your feedback! that is interesting! we have others G30 chassis with FP4.5.2 and FP4.1.0 with the same appearance (notApplicable). Is there a reason you not use cardAdminStatus ? |
Hi @Bierchermuesli |
Adding
cardAdminStatus
state to discovery so we can check the real operational state of a module. If thecardMode
is notApplicable (not normal nor regen) it will be skipped as it does not make much sense on my release. I used a G30 with 4.7.0. @nickhilliard has tested with 3.0.0 anno 2019CORIANT-GROOVE-MIB says:
Actually I don't get it what
cardMode
should do.ATM AdminState is ignored in polling.
Before
After
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply 15782
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.