Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ubiquiti UISP Fiber OLT XGS #15742

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pozar
Copy link

@pozar pozar commented Jan 13, 2024

fixes #15741

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@pozar
Copy link
Author

pozar commented Jan 13, 2024

A fix for #15741

@PipoCanaja PipoCanaja added the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Jan 14, 2024
Copy link

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja
Copy link
Contributor

Hi @pozar
Welcome in the project and thank you for your PR. Could you please have a look at the tests and let us know if you have issues ?
Thanx

@pozar
Copy link
Author

pozar commented Jan 14, 2024

I tried running the tests but at step 2, I get this error...
`librenms@librenms:~$ ./scripts/save-test-data.php -o edgeosolt -v edgeosolt
Starting snmpsim listening on 127.1.6.1:1161...
Traceback (most recent call last):
File "/usr/bin/snmpsimd", line 576, in
'|'.join(log.gMap),
AttributeError: module 'snmpsim.log' has no attribute 'gMap'

Failed to start Snmpsim. Scroll up for error.
librenms@librenms:~$
`

@pozar
Copy link
Author

pozar commented Jan 14, 2024

Running lnms dev:check with this PR patched I get the attached output
tests.txt

It seems to be testing OSs that are not part of this PR.

@PipoCanaja
Copy link
Contributor

The target here is to provide a new pair of files for your UISP Fiber OLT XGS device.

you need to record the SNMPREC file and generate the JSON associated file. If the JSON fails on your device, I'll do it. But the SNMPREC can only be done with the real device (it is a record of all necessary SNMP data).

Generation can be done like this :
./scripts/collect-snmp-data.php -h <yourDeviceId> -v 'uisp-fiber'

And file should be attached to this PR

JSON should be done like this:
./scripts/save-test-data.php -o edgeosolt -v 'uisp-fiber'

If it fails, I'll do it.

@pozar
Copy link
Author

pozar commented Jan 17, 2024

@PipoCanaja ...
The following fails...

librenms@librenms:~$ ./scripts/save-test-data.php -o edgeosolt -v 'uisp-fiber'
Starting snmpsim listening on 127.1.6.1:1161... 
Traceback (most recent call last):
  File "/usr/bin/snmpsimd", line 576, in <module>
    '|'.join(log.gMap),
AttributeError: module 'snmpsim.log' has no attribute 'gMap'

Failed to start Snmpsim. Scroll up for error.
librenms@librenms:~$ 

@pozar

This comment was marked as resolved.

@laf

This comment was marked as resolved.

@pozar
Copy link
Author

pozar commented Jan 22, 2024

Are you looking for the edgeosolt_uisp-fiber.snmprec file (attached)?
edgeosolt_uisp-fiber.snmprec.gz

@PipoCanaja
Copy link
Contributor

Are you looking for the edgeosolt_uisp-fiber.snmprec file (attached)? edgeosolt_uisp-fiber.snmprec.gz

Yes, exactly. Please put it in the PR at its location.

@pozar
Copy link
Author

pozar commented Jan 26, 2024

Rats... What is next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UISP Fiber OLT XGS is being "discovered" as "Inteno GW"
3 participants