mysql-stats rewrite #291
Open
mysql-stats rewrite #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
crcro
commented
Apr 20, 2020
crcro
commented
- python3
- new apps json data export
new apps json data export
|
Looks good, is there a matching PR to handle this in LibreNMS? |
|
I will have an update to this commit to handle diffs between reads and some innodb insert buffer changes (the output from SHOW INNODB ENGINE STATUS is a bit different now). i will make the PR to handle this in LibreNMS soon (mostly done) |
fixed innodb insert buffer stats
2 tasks
|
i miss a configfile to configure login credentials to database |
| file.write(str(entries)) | ||
|
|
||
| export = {"data": new_entries, "error": "0", "errorString": "", "version": "1"} | ||
| data = re.sub(' ', '', json.dumps(export)) |
There was a problem hiding this comment.
space removement not needed
Example:
https://github.com/librenms/librenms-agent/pull/258/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.