Update init checks to be less restrictive #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question, how do you clear possibly incompatible cached data from redis? |
|
I haven't had the "need", but from the current test 22.6 to 23.4 I didn't find any "incompatible issues". |
duhow
commented
Apr 28, 2023
crazy-max
requested changes
Jul 21, 2023
|
@crazy-max can you review changes again and validate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #283 restrictive check, Docker images after
22.6.0are not working properly for us.We are running LibreNMS in Kubernetes, where we have the
config.phpmounted asConfigMap(read-only for the file system), and also Redis has disabledFLUSHDBas a safety measure.Changes applied in here:
config.dfolder initially.config.dfiles only if folder is writable.chownfolders only if are writtable.cache:clearfails. (Redis)