Add a ratbag_dispatch() method to allow hooking into a mainloop #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from libinput with a few renames, this gives us the ability for drivers to register file descriptors for events and process those events. The calling process (i.e. ratbagd) needs to call ratbag_dispatch() whenever something happens on the fd. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
bentiss
approved these changes
Sep 22, 2017
|
Probably missing something obvious here but what would such a user be in this case? We currently have the DBus API that also allows to monitor for changes; and since we don't export libratbag as a library anymore I fail to see how this is relevant. |
|
any event processing inside libratbag will need it. This is internal API, not external so it's ratbagd that keeps calling into libratbag to process stuff - invisible to the client. Potential users are any driver API that uses e.g. dbus to communicate with some other API (like openrazer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something we'll eventually need when we start monitoring events. We don't have a user for this just yet, so we shouldn't merge it.
I'm sending this as PR now because the code is written and I think that's the approach we want. So once we need it, we can rebase this and push it out.