Add G705 Mouse support #1586
Add G705 Mouse support #1586
Conversation
|
In order to get the mouse to work while connected with the lightspeed receiver, But this makes the test As as understand it, the kernel is supposed to support logitech receiver, so that each device connected to the receiver appears as a wired one, but that's not happening with this device. |
Use device pid instead of receiver pid requires a kernel supporting the PID 0xc547 receiver See libratbag#1119
This field seemed to be unused in previous profile format. But with the profile format 0x05 it appears to control whether or not the custom animations are used.
|
Hi ! |
| // This field needs to be zero for leds to work in G705 | ||
| // If a non zero value is set, custom animation will be used instead |
There was a problem hiding this comment.
I think this comment should go above the custom_animation_g705 struct field instead.
| @@ -2959,6 +2958,10 @@ hidpp20_onboard_profiles_write_profile(struct hidpp20_device *device, | |||
|
|
|||
| memcpy(pdata->profile.name.txt, profile->name, sizeof(profile->name)); | |||
|
|
|||
| // This field needs to be zero for leds to work in G705 | |||
| // If a non zero value is set, custom animation will be used instead | |||
| pdata->profile.custom_animation_g705 = 0x00; | |||
There was a problem hiding this comment.
Could you put this under a check for G705? Just to make sure we don't accidentally introduce regressions for other devices. I don't have any experience with HID++ myself, so we should be extra careful.
This device needs the led effect settings for the first (and only) led cluster to be written in the second led slot in the profile data.
I wasn't sure how to do this without breaking the compatibility with other devices, so I conditioned it the profile type, but maybe there's a better way.