Steelseries sensei ten #1184
Open
Steelseries sensei ten #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new version. |
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
from
c122c67
to
de6ac2e
Compare
|
@FFY00 Done |
FFY00
requested changes
Jun 21, 2021
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
2 times, most recently
from
749ef88
to
2dbd010
Compare
|
Please don't merge yet, I'll have to do some more rework. |
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
from
2dbd010
to
3ee8892
Compare
|
Maybe for now this could be fixed? so, allways 5 profiles, while those features are not implemented |
|
@perigoso Sure. Unfortunately I don't have access to the device right know, so I won't be able to test. |
|
@perigoso Any hints on how to force libratbag to always have five active resolutions in a profile? |
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
from
3ee8892
to
4486cce
Compare
|
actually, the problem here was trying to set them to 0 right? maybe set them to the minimum dpi by default? |
|
Or we take a list of resolutions, sorted by their index, and use that. This would not require us to create placeholder resolutions and we could reuse the currently logic nearly as-is. (Please note I am really hazy on the details of this driver and libratbag in general) |
|
Honestly I'm not familiar with the code base either, you probably know more about that one driver in particular than me. We have a lack of maintainers, I only now started to actively try to help. |
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
from
4486cce
to
969ae49
Compare
|
@perigoso The current code should now work without any superfluous resolutions on the device by sometimes loosing the order. |
|
There's been an unrelated bugfix in this driver so you'll have to rebase if you can |
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
from
969ae49
to
37b1425
Compare
|
@perigoso I fixed the conflicts, but as I said, I can't test this at the moment. |
|
Will you be able to test eventually? or do you no longer have access to the device? |
|
@perigoso I'll have to flash the vanilla firmware again. I'll try to find some time in the coming days. |
|
ah, right, you had that running on openinput, did you manage to get it working? |
|
It works as a basic mouse, but I think I skipped uploading the sensor firmware. If somebody can send me a full dump of the original flash chip that would be useful. |
|
I'll receive a new sensei ten during this week. I can try to help by providing a dump but I don't know how to do it and what tools are needed for it. (I can learn and find the tools) |
|
@b0ywearngtyts Thanks, you would have to open the device and directly read the flash chip on the PCB via probes. |
|
@sur4y What the output of |
|
@t-8ch Here you go: |
|
Sorry for the late response. |
|
No worries! Also, with the fix in that command, we finally managed to dump it! Not really sure what most of this means but this is the result of |
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
from
de63d5c
to
76c63b4
Compare
|
@sur4y Can you try the latest version of the PR? It should get rid of the segmentation fault and also provides more diagnostics into what actually goes wrong. |
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
from
be57cbc
to
41aa0f2
Compare
|
@t-8ch No crashes this time! Thank you so much! How should I be testing the mouse from here on? Is there anything else I can do? |
|
@sur4y Yeah, progress :-) |
|
@t-8ch No issues again. |
|
@sur4y Are you sure you recompiled after the last update? The debug logs are missing. |
|
I think I must have missed something, I am sorry. This is the new output: Also, both Please let me know if I can be of help further =] |
|
And another try |
|
Here you go: |
|
And again |
|
Sorry for the late response, here: |
|
This looks better. Does ratbagctl detect it? |
|
Sure I can! Also |
|
Nice, so now it would be up to you to test the functionality :-) |
t-8ch
force-pushed
the
steelseries-sensei-ten
branch
from
7e5ec30
to
4ee1df4
Compare
|
As my old mouse (G403) is loosing is functionality I wanted to buy a new mouse that is supported by libratbag / piper and only checked the wiki devices page. So now I have a Sensei Ten and needed libratbag in the version of this PR on my system. My initial test results:
|
|
You could use piper to test all the functionality
|
|
I want to apologize for taking this much time to answer. The main problem seems to be the resolution configuration. Although setting LEDs and buttons works fine saving the configuration messes up the resolution settings as described previously. I did some tests with piper and ratbagctl and could reproduce some problems this way:
|
Pentadrago
reviewed
May 12, 2023
| @@ -462,6 +489,7 @@ steelseries_write_dpi(struct ratbag_resolution *resolution) | |||
| msg.msg.parameters[2] = i; | |||
| break; | |||
| case 2: | |||
| case 4: | |||
There was a problem hiding this comment.
Is this line necessary? If I understood the code correctly in case of device_version 4 the other method steelseries_write_resolutions_v4 is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the Steelseries Sensei Ten mouse.
It mostly uses the v2 protocol but differs slightly in some places.
How should this be handled?
Fixes #860
Depends on #1183