feat: invoke onProgress callback with events during routing #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
changed the title
maschad
requested changes
Oct 25, 2023
| @@ -235,7 +244,15 @@ export interface Libp2pEvents<T extends ServiceMap = ServiceMap> { | |||
| * }) | |||
| * ``` | |||
| */ | |||
| 'start': CustomEvent<Libp2p<T>> | |||
| 'start': CustomEvent<Libp2p< | |||
There was a problem hiding this comment.
This is pretty verbose, should we have this as a seperate interface?
There was a problem hiding this comment.
I'm not a massive fan of how this is implemented so I'm certainly open to suggestions of how to make it simpler.
The idea is to derive the types of content/peer routing progress events you'll get from the config so they can be type safe. I not sure it's reliably possible, and it leads to these sorts of generics contortions - we may be better off just making it untyped.
There was a problem hiding this comment.
Yes I agree there, I don't see any type safety benefits as is, I think we are better off with
export interface Libp2pEvents<
Services extends ServiceMap = ServiceMap,
ProgressEvents extends ProgressEvent = ProgressEvent
> {
'start': CustomEvent<Libp2p<Services, ProgressEvents>>;
'stop': CustomEvent<Libp2p<Services, ProgressEvents>>;
}given the DHTContentRouting class already specifies the ProgessEvent types in it's methods.
Allow passing an `onProgress` callback to the peer/content routers that can receive DHT query events. Refs #1574
achingbrain
force-pushed
the
feat/call-progress-callback-for-content-and-peer-routing
branch
from
616b0a8
to
61aa0ce
Compare
achingbrain
force-pushed
the
main
branch
18 times, most recently
from
bd30ffd
to
d153d4c
Compare
achingbrain
force-pushed
the
main
branch
19 times, most recently
from
242fd96
to
bca8d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing an
onProgresscallback to the peer/content routers that can receive routing events.Refs #1574