unified STM32 F2 and F4 ADC peripheral defines and added F2 include #1525
+228
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlp
reviewed
Feb 6, 2024
include/libopencm3/stm32/f4/adc.h
Outdated
| void adc_disable_vbat_sensor(void); | ||
|
|
||
| END_DECLS | ||
| #include <libopencm3/stm32/common/dma_common_f24.h> |
There was a problem hiding this comment.
d'oh! I only built my project with F2 support, so I missed this erroneous copy-paste.
There was a problem hiding this comment.
That's one of the reasons I was against supporting people building only part of the project :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on suggestion in Issue #988