Small makefile change to clean up debugging path resolutions. #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files. This helps resolve file locations during debugging more cleanly.
|
Hi, As a simple contributor I can't see any problem with this change, so I approve it, but @karlp always has interesting and accurate remarks about the structure of this project, and I cant speak for them. Did you make sure that no other place in the build infrastructure would benefit from a similar change? Thats the only detail I can think about. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the compilation command to utilize absolute paths for source files. This helps resolve file locations during debugging more cleanly.
This change avoids confusion in debuggers with trying to resolve relative paths to track down the source files.