NEEDSTEST: stm32f0: comparator: fix memory accesses #1463
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: libopencm3#1289 While it had seemed a clever trick to access COMP_CSR as two 16bit registers, apparently in the real world, this didn't behave as expected. Switch the register definitions to 32bit and adjust all the functions to auto select the correct portion of the register. NEEDSTEST: this has been coded only, I personally have no code using this, but it seems like the correct approach, and the current code is obviously broken. Signed-off-by: Karl Palsson <karlp@tweak.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1289
While it had seemed a clever trick to access COMP_CSR as two 16bit registers, apparently in the real world, this didn't behave as expected.
Switch the register definitions to 32bit and adjust all the functions to auto select the correct portion of the register.
NEEDSTEST: this has been coded only, I personally have no code using this, but it seems like the correct approach, and the current code is obviously broken.
Signed-off-by: Karl Palsson karlp@tweak.au