Extent timer API by timer get direction #1441
Open
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Target coding style issues. No functional change. Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
When the timer is in encoder interface mode, the DIR bit can be modified by hardware. Add function to get the count direction bit. [Benedikt Spranger <b.spranger@linutronix.de] * keep attention of review comments (pull reqest libopencm3#1355) Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a follow up to pull request #1355 .
I stumbled over this pull request to avoid open coding.
Since there was no progress for a long time I reworked that patch and keep attention to the review comments.
Regards
Benedikt Spranger