Make sure the testsuite does not leave artifacts behind #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it would be better just to use |
|
It could be done and I certainly wouldn't be against it, but this is really a drive-by patch. It was simple enough that I submitted a patch instead of opening a bug report. I'm not sure I have the motivation (even if it's a pretty simple change) to make extra changes though... Bonus points: I've tested this patch and it works :) Thank you for caring and for your work on this project though. |
Evidlo
force-pushed
the
clean_testsuite
branch
from
1a22f84
to
1d50740
Compare
Evidlo
force-pushed
the
clean_testsuite
branch
from
1d50740
to
23d611e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
While working on the Debian package for pykeepass, I found out when the testsuite is ran,
db_dump.xmlis left behind in the CWD.This commit makes so that it runs cleanly.
Cheers,