Adds OnPushRemoteProgress handler to PushOptions #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NativeMethods for receiving text updates from the remote already exists and are used in the
FetchOptions. This simply adds the existing handler toPushOptionsmaking it possible to configure a callback for receiving text updates from the remote.No tests have been added for this PR, as its not possible to get remote updates when pushing to local bare repositories. I have integration tests locally that shows this working, but a remote repository is needed for it to be successful.
Hoping that the simplicity of this makes it straight forward to merge.
This is discussed here #642