Simple warnings framework #6485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2023 13:23
Invoke the new warning callback for `safe.directory` failures.
|
This is the fourth PR to add warnings. 😅 This one is - I think - the simplest, at least for us. We can just define and invoke warnings without a lot of ceremony. This does mean that the user basically has a I think that's okay? With the possible exception of having to deal with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a potential simple warnings framework.
I think that the names 'continue' and 'ignore' are probably rather misleading. But bikeshedding on the naming aside, I think that this will help #6430