refs: make git_reference_cmp consider the name
#6346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`git_reference_cmp` only considers the target of a reference, and ignores the name. Meaning that a reference `foo` and reference `bar` pointing to the same commit will compare equal. Correct this, comparing the name _and_ target of a reference.
nasso
reviewed
Jul 8, 2022
|
|
||
| GIT_ASSERT_ARG(ref1); | ||
| GIT_ASSERT_ARG(ref2); | ||
|
|
||
| if ((ret = strcmp(ref1->name, ref2->name)) != 0) |
There was a problem hiding this comment.
Why is it necessary to continue inspecting the references if they have identical names? Is it so that "outdated" git_reference values compare as different?
There was a problem hiding this comment.
Right, that's the most likely scenario, I would expect. You load a reference, mutate it, and then check an existing reference to the new reference.
|
Maybe add git_reference_cmpname or rename git_reference_cmp to git_reference_cmptarget to make this more clear? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git_reference_cmponly considers the target of a reference, andignores the name. Meaning that a reference
fooand referencebarpointing to the same commit will compare equal.
Correct this, comparing the name and target of a reference.
This appears to be an oversight, as
git_reference_cmpwas added as a helper method. Despite that, this is a breaking API change. We'll target libgit2 2.0 for this change.Fixes #6337