rpm: Fix Visual Studio compiler warnings #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum header size is used at multiple instances in the code. Clarify its meaning by using a definition. Also, while in an if-block which checked if rpm->pos is 16, use the value to avoid a warning with Visual Studio and to clarify that more data will follow beginning at the current position. Fixes: warning C4244: '=': conversion from 'uint64_t' to 'long', possible loss of data
It is used in conjunction with avail_in and total, which are ssize_t as well. Reduces the amount of required casts.
Introduce a new static inlined function which allows type-safe conversion from uint64_t to size_t even on 32 bit systems. While at it, turn variable n into size_t because it's used as argument to memcpy and is always supposed to indicate length of heap operations, not files. Fixes: warning C4244: 'function': conversion from 'uint64_t' to 'size_t', possible loss of data
mmatuska
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of simply adding casts, this PR reduces the total amount of casts needed:
hposinstead of magic number to highlight that additional bytes will be parsedThe latter two changes can be performed because the if-block in question already ensures that
hposand16are identical.