Resolve TODO: Return uname and gname overrides #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatuska
force-pushed
the
ataridreams/autoconf
branch
2 times, most recently
from
d090530
to
1d951c4
Compare
evelikov
reviewed
May 7, 2024
| { | ||
| static char errbuff[128]; | ||
| const char *u, *ue, *g; | ||
|
|
||
| *uid = -1; | ||
| *gid = -1; | ||
|
|
||
| *uname = NULL; | ||
| *gname = NULL; | ||
|
|
There was a problem hiding this comment.
The caller (rightfully so) does not check any of the arguments when the function fails. So the default initialization above (names and ids) alongside the one in the error path below can be dropped IMHO.
There was a problem hiding this comment.
To avoid complicating the code (adding else statements as applicable) one can use local variables instead and *outputvar = localvar at the very end of the function.
evelikov
reviewed
May 7, 2024
evelikov
approved these changes
May 7, 2024
mmatuska
force-pushed
the
ataridreams/autoconf
branch
2 times, most recently
from
5c0db0d
to
5844b22
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mmatuska
force-pushed
the
ataridreams/autoconf
branch
2 times, most recently
from
4954f2d
to
1bbaef3
Compare
Simplify introducing a struct cpio_owner Co-authored-by: Martin Matuska <martin@matuska.de>
mmatuska
force-pushed
the
ataridreams/autoconf
branch
from
1bbaef3
to
7078929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of #2061