Allow setting charset for archive. #1966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes archive.current_code so that the caller can explicitly specify a charset instead of relying on the default locale. This is important for platforms like Android and iOS (and when compiled without iconv), because nl_langinfo isn't available before Android API 26, and on iOS nl_langinfo always returns US-ASCII. And the caller should be able to specify the charset they want to work with for each archive, instead of relying on a global state. This change is updating the ZIP writing support to respect this per-archive charset when setting the UTF-8 flag as well. Bug: libarchive#1572
|
@kientzle what do you think of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes archive.current_code so that the caller can explicitly specify a charset instead of relying on the default locale.
This is important for platforms like Android and iOS (and when compiled without iconv), because nl_langinfo isn't available before Android API 26, and on iOS nl_langinfo always returns US-ASCII. And the caller should be able to specify the charset they want to work with for each archive, instead of relying on a global state.
This change is updating the ZIP writing support to respect this per-archive charset when setting the UTF-8 flag as well.
Bug: #1572