Netgen submodule #3793
Open
Netgen submodule #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roystgnr
force-pushed
the
netgen_submodule
branch
from
763f79e
to
22f8ae8
Compare
|
Job Coverage on 9242daf wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
|
Well, at least I didn't break installcheck in the default --disable-netgen configuration; that's a plus. Let me try enabling netgen by default and make sure CI catches the issues then. |
|
Okay, now we're seeing the real issues; enough to prompt cleanup of the cmake options and a stray clang warning, at least. And I think a proper manual install (with patchelf on Linux, install_name_tool on OSX, thankfully this was already figured out in moose.mk at one point...) will fix the remaining issues. |
Right now this is just a test for include directory and linker issues, but it'll also be necessary when we're actually using netgen...
This doesn't really do anything but create and delete an empty mesh, but it helped me work out more linker and namespace issues, and it'll be a good place to put tests for any issues that we suspect aren't in our shim code.
We need a lot more here but this is a start
Fortunately recent clang versions flag this with a warning and our CI for them treats warnings as errors. Let's mark the newly-virtual functions "override" in the subclasses while we're at it.
In the medium term I'm hoping this will be robust enough to leave on by default; in the short term I want our CI to yell at me about any errors this triggers.
We don't use it yet, we don't have plans to use it in the near future, and if cmake thinks we want it but can't find it then it refuses to build the parts of netgen we do use.
We don't need it, and it demands Tcl/Tk which we may not have and may not want to download.
Our Civet recipe was complaining about the lack of pybind11, but I've seen other weird Python errors here too.
This lets us (re)tetrahedralize volume meshes by turning their (outermost) surface into a surface manifold fitting our existing API. We'll still need to tweak this to save interior points as Steiner points for compatibility with our 2D triangulator behavior.
Why did I not have this API take a reference??? Ought to fix that and deprecate the existing one...
Predicated on tet support in all_tri(), of course...
And get rid of an annoying unimplemented declaration (we have the functionality under another name though) while we're at it.
This isn't going to be as useful as I'd feared, if we can't support no-refinement cases, but it's done and it's working for auto-refinement cases.
roystgnr
force-pushed
the
netgen_submodule
branch
from
9242daf
to
362982d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't in working order (I'm sure it'll fail installcheck, most of the features aren't there...) but it's passing the most basic test now and probably good enough to let others see it and to make sure I haven't regressed anything in other tests.