Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic face element (crazy hack) #3521

Draft
wants to merge 7 commits into
base: devel
Choose a base branch
from
Draft

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Apr 17, 2023

Just making this PR because the corresponding MOOSE PR idaholab/moose/pull/23748/files is not a convenient way of looking at these changes.

@dschwen dschwen requested a review from roystgnr April 17, 2023 19:49
@moosebuild
Copy link

moosebuild commented Apr 17, 2023

Job Coverage on 5455d11 wanted to post the following:

Coverage

5bb12f #3521 5455d1
Total Total +/- New
Rate 61.90% 61.90% -0.00% 40.00%
Hits 66921 66920 -1 2
Misses 41186 41191 +5 3

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 40.00% is less than the suggested 90.0%

This comment will be updated on new commits.

/**
* \returns True if the element supports libmesh quadrature
*/
virtual bool has_quadrature_support() const { return false; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
virtual bool has_quadrature_support() const { return false; }
virtual bool has_quadrature_support() const override { return false; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants