Options for restricting solves to unconstrained DoFs only #3460
+456
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be called from within a solver even if it doesn't have access to the System.
Still need a PetscDiffSolver implementation
This helps encapsulate some of the tricky distinctions between system subclasses and their associated solvers
|
So not only is the new PetscDiffSolver option not working, the old functionality has regressed. Didn't even think to check for that by hand... |
roystgnr
force-pushed
the
solve_unconstrained
branch
from
dcb2c7e
to
61c30df
Compare
|
Job Coverage on 61c30df wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the right interface (there's at least some PetscDiffSolver encapsulation that I've broken with
public:but should redo properly withfriend), and I'm not sure this is the right implementation (the related code already in PetscLinearSolver was creating a submatrix, but this is mainly for efficiency so maybe we should be building a composite matrix in the first place?), and it's not complete (PetscLinearSolver and NewtonSolver are working; PetscDiffSolver is giving me a zero pivot on the preconditioner; PetscNonlinearSolver isn't implemented).But the pre-vacation work year is starting to run low for me, so I'm putting this up to see if CI manages to see even more problems than I do.