Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked upload callbacks features + axios instead of custom requests #262

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bieli
Copy link

@bieli bieli commented Jan 5, 2019

We need this feature for chunked upload processing with dedicated callbacks in our application.

@bieli
Copy link
Author

bieli commented Jan 11, 2019

@lian-yue What do you think about below refactoring (axios insteadof XMLHttpRequest) and adding new callbacks features ?

I preparing set of improvements in specific UI solution - object storage web client.
We have been creating UI with multi upload objects (based on S3 API) supporting sessions on client/webbrowser side (using IndexedDB).
Additional backend session storage for uploaded chunks isn't needed. It's possible with callback features from this Pull Request.

Of course axios it's stadard in many UIs. This change is helpfull for local dev. backends calls easy mocking. We have settings for HTTP client in our UI and this change allow us propagating the same setup to to lower layer (to axios in this component).

@bieli bieli changed the title chunked upload callbacks freature chunked upload callbacks features + axios instead of custom requests May 10, 2021
@bieli
Copy link
Author

bieli commented May 10, 2021

@lian-yue Any comments for below PR with callbacks and switching to axios (standard in today JS/TS impl.) ? Below code was deployed and tested on production with ~1k internal users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant