kubevirt single node install path rework and upgrades. #3838
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3838 +/- ##
=======================================
Coverage 17.51% 17.51%
=======================================
Files 3 3
Lines 805 805
=======================================
Hits 141 141
Misses 629 629
Partials 35 35 ☔ View full report in Codecov by Sentry. |
andrewd-zededa
force-pushed
the
andrewd-kubevirt-longhorn
branch
3 times, most recently
from
dec0ef9
to
4c5e659
Compare
| while true; do | ||
| if [ -e "$filename" ]; then |
There was a problem hiding this comment.
isn't it possible to check directly in the condition of the while loop that $filename exists instead of creating an endless loop and then inside check if the file exists and break if it does not?
There was a problem hiding this comment.
certainly yes
There was a problem hiding this comment.
until [ -e "$filename" ]; do
...
doneis what are you looking for...
pkg/kube/nsmounter
Outdated
|
|
||
| PROC_DIR="/proc" | ||
|
|
||
| os_distro_talos="talos" |
There was a problem hiding this comment.
Is this from an existing file with talks support and you're adding eve support to it? If so can we upstream the eve support?
There was a problem hiding this comment.
yes the upstream work is going to be submitted soon
Longhorn:
Bump to latest version 1.6.0 including upstream change to
find the correct iscsid pid when running k3s in a container.
nsmounter replacement to fix PID enabling RWX PVC mounts
findutils: needed for -regextype option
nfs-utils: for RWX (nfs) PVCs
longhorn-generate-support-bundle.sh:
request a support bundle containing complete lh logs
written to longhornsupportbundle_*.zip in
/persist/newlog/kube/
Lowered iSCSI queue depth to handle large CDI volume uploads.
This is temporary until performance testing completes.
Set default disk path (pool) to /persist/vault/volumes
K3s:
Bump to version v1.28.5+k3s1
k3s-pod-logs.sh: collect kube /var/log/pods/ contents
for complete k3s pod logs. CDI, kubevirt, kubesystem, ...
On k3s restarts compress /persist/newlog/kube/k3s.log to
k3s.log.restart.<restart count>.gz for root cause analysis.
Otherwise regular k3s log rotation can lose the crashes after
the system becomes stable for some time.
Config:
Switched from etcd to SQLite for perf on
smaller nodes.
Containerd:
containerd-user root moved to /persist/vault/containerd
CDI:
Bump to version 1.57 to include qcow import readahead fix
Kubevirt:
Bump to version 1.1.1
Yetus fixes in kubevirt-features.yaml
Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
andrewd-kubevirt-longhorn
branch
from
4c5e659
to
c1c22e4
Compare
|
@eriknordmark @zedi-pramodh |
Are there more parts coming? I might want to wait to cut 12.1.0 until they are all in. |
|
@eriknordmark sorry missed this, I believe all small broken up PRs of this are submitted. I think just waiting on merge of 3893 now. |
|
@andrewd-zededa has all of these been split into separate PRs so we can close this PR? |
Longhorn:
Bump to latest version 1.6.0 including upstream change to
find the correct iscsid pid when running k3s in a container.
nsmounter replacement to fix PID enabling RWX PVC mounts
findutils: needed for -regextype option
nfs-utils: for RWX (nfs) PVCs
longhorn-generate-support-bundle.sh:
request a support bundle containing complete lh logs
written to longhornsupportbundle_*.zip in
/persist/newlog/kube/
Lowered iSCSI queue depth to handle large CDI volume uploads.
This is temporary until performance testing completes.
Set default disk path (pool) to /persist/vault/volumes
K3s:
Bump to version v1.28.5+k3s1
k3s-pod-logs.sh: collect kube /var/log/pods/ contents
for complete k3s pod logs. CDI, kubevirt, kubesystem, ...
On k3s restarts compress /persist/newlog/kube/k3s.log to
k3s.log.restart..gz for root cause analysis.
Otherwise regular k3s log rotation can lose the crashes after
the system becomes stable for some time.
Config:
Switched from etcd to SQLite for perf on
smaller nodes.
Containerd:
containerd-user root moved to /persist/vault/containerd
CDI:
Bump to version 1.57 to include qcow import readahead fix
Kubevirt:
Bump to version 1.1.1
Yetus fixes in kubevirt-features.yaml
Including debuguser role by @naiming-zededa .