Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE YET ] Integrate Hailo 8 FW #3719

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Jan 26, 2024

No description provided.

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@rucoder rucoder requested a review from rene as a code owner January 26, 2024 12:30
@rucoder rucoder requested review from eriknordmark and removed request for rene January 26, 2024 12:30
@github-actions github-actions bot requested a review from rene January 26, 2024 12:31
@rucoder rucoder requested review from rene and removed request for rene January 26, 2024 12:34
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0abffd8) 19.61% compared to head (f39bd53) 19.60%.
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3719      +/-   ##
==========================================
- Coverage   19.61%   19.60%   -0.02%     
==========================================
  Files         232      232              
  Lines       50770    50770              
==========================================
- Hits         9959     9953       -6     
- Misses      40088    40094       +6     
  Partials      723      723              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -61,6 +61,12 @@ ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM4345C0.hcd .
ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM43430B0.hcd .
ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM4345C5.hcd .

# Hailo GPU firmware
# we've got a written permission to include this firmware into EVE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think we must take this with precaution. Although it's a firmware blob, so we are not talking about source code to be included on EVE, this written permission should be compatible with Apache 2.0, which means that it should not forbid us in anyway from any of the permissions guaranteed by our license: rights to use the software as it is, rights to change it (EVE), rights to share it... since it's a firmware blob, perhaps the most important is the right to share it as we wish (within EVE, of course)... I think it's important to include a license file here, we do have proprietary firmware in this package (i.MX, NVIDIA), but they have specific (proprietary) licenses that allows to share, pack with EVE, etc, i.e., which doesn't break the terms of our license...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene yes, sure. I've submitted this PR as a placeholder so I do not loose the code. still waiting for confirmation and proper license file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be feasible to download it during VM deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants