Bump up XEN version to 4.18.0 #3534

rucoder · 2023-10-26T18:25:25Z

Highlights:

QEMU 8.0.4
libgcc instead of musl

TODO:

port CPU pinning patches @OhmSpectator is working on it
Some patches have to be cleaned up. Need to update Commit messages in patches based on original PR descriptions. Original patch files were not generated using git format-patch and lack all required information
Need to update unit tests according to new domain config file
Test XEN on QEMU and HW
Test KVM on QEMU and HW
Test if apk add ninja-build does the trick instead of building ninja from source
- ninja-build is not real ninja, but 'samurai' works fine
XEN 4.18.0-rc5 is out. Up-merge to it
XEN 4.18 is finally out. Up-merge to it

@eriknordmark Looking at XEN release page at https://downloads.xenproject.org/release/xen/ I would expect XEN 4.18.0 in December this year.

deitch · 2023-10-26T18:32:38Z

I had to build ninja from source since Alpine dropped a support for it in 3.8

It looks like it has support. apk add ninja-build (plus some weird compatibility stuff with apk add ninja-is-really-ninja). Does that not work?

rucoder · 2023-10-26T18:37:20Z

I had to build ninja from source since Alpine dropped a support for it in 3.8

It looks like it has support. apk add ninja-build (plus some weird compatibility stuff with apk add ninja-is-really-ninja). Does that not work?

oh, thanks for finding it! I'll give it a try.

eriknordmark · 2023-10-26T20:09:26Z

pkg/xen/Dockerfile

@@ -20,7 +20,7 @@ RUN [ -f "$(basename ${XEN_SOURCE})" ] || tar --absolute-names -xz < /xen.tar.gz
 WORKDIR /xen/xen
 COPY *.patch arch /tmp/
 RUN cp /tmp/"$(uname -m)"/*.patch /tmp/
-RUN for p in /tmp/*.patch ; do patch -p1 < "$p" || exit 1 ; done
+#RUN for p in /tmp/*.patch ; do patch -p1 < "$p" || exit 1 ; done


Should we instead delete the content of the patch directories? Or will we need some of them?

We still need them, but it's just a temporary workaround to avoid applying the not-yet-ported patches.

(it should be converted to a draft PR)

rene · 2023-10-27T09:15:59Z

pkg/pillar/hypervisor/kvm.go

@@ -108,8 +103,6 @@ const qemuConfTemplate = `# This file is automatically generated by domainmgr
  driver = "intel-iommu"
  caching-mode = "on"
 {{ end }}
-[realtime]


According to QEMU's documentation:

The -realtime mlock=on|off argument has been replaced by the -overcommit mem-lock=on|off argument.

Even if mem-lock=off is the default it can make sense to let this option explicit in the config... or at least explain the removal in your commit message

Essentially, this option enables or disables mlock() call (https://www.man7.org/linux/man-pages/man2/mlock.2.html). This is probably workload-specific.

rene · 2023-10-27T09:17:09Z

pkg/pillar/hypervisor/kvm.go

@@ -54,12 +54,7 @@ const qemuConfTemplate = `# This file is automatically generated by domainmgr
 [machine]
  type = "{{.Machine}}"
  dump-guest-core = "off"
-{{- if .DomainStatus.CPUs }}


Why are these being removed? I think it will affect the unit tests, so you need to update them as well (same for the realtime config).... the removal reason should also be explained in the commit message...

Edit: I see... you didn't port @OhmSpectator patches yet...

rene · 2023-10-27T09:22:16Z

pkg/xen-tools/Dockerfile

 ENV PKGS_arm64 libfdt

 RUN eve-alpine-deploy.sh

+ADD https://github.com/ninja-build/ninja.git#release /ninja
+WORKDIR /ninja
+RUN python3 ./configure.py --bootstrap


Do we really need all these layers? Is this build too heavy? I think you could squash all these commands into a single RUN....

@rene QEMU now uses ninja. I couldn't find APK for it in Alpine so it was faster to build it from source. Now @deitch ponited out that it is called ninja-build. I still need to give it a try

@rene Are you sure intermediate layers are stored? It really makes it less readable to have these long blocks of RUN all connected with &&

Yes @christoph-zededa , that's the definition of RUN command on docker... @rucoder , I understand that you need to build ninja, that's fine, my point is that you can just group the commands (using &&) instead of use multiple RUN commands and create one layer per command....

@rene since docker is using buildkit I have not seen them.

rucoder · 2023-10-27T12:51:26Z

just to clarify: this is a WIP and very DRAFT PR for experementing with latest XEN/QEMU so I can share my work with other people. I've updated the description

OhmSpectator · 2023-10-27T17:01:18Z

The new QEMU version natively supports CPU Pinning options, making the CPU pinning patches unnecessary. Here is the branch that adapts Pillar to use these options:
https://github.com/OhmSpectator/eve/tree/feature/use-native-qemu-cpu-affinity
It's done on top of this PR.

rucoder · 2023-10-29T01:18:58Z

I had to build ninja from source since Alpine dropped a support for it in 3.8

It looks like it has support. apk add ninja-build (plus some weird compatibility stuff with apk add ninja-is-really-ninja). Does that not work?

@deitch ninja-build is not ninja :) but samurai package does the trick

- I had to build ninja from source since Alpine dropped a support for it in 3.8 Highlights: - QEMU 8.0.4 - libgcc instead of musl Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

rucoder requested review from rene and rouming as code owners October 26, 2023 18:25

eriknordmark reviewed Oct 26, 2023

View reviewed changes

rene reviewed Oct 27, 2023

View reviewed changes

eriknordmark marked this pull request as draft October 27, 2023 11:29

mikem-zed mentioned this pull request Oct 27, 2023

[WIP][EXPERIMENTAL] Upmerging xen-tools to xen 4.17.2 #3500

Closed

rucoder force-pushed the rucoder/xen-4.18.0-rc4 branch from 480fd81 to 79482da Compare October 31, 2023 15:06

rucoder added 2 commits October 31, 2023 15:47

Bump up XEN version to 4.18.0-rc4

79d0c98

- I had to build ninja from source since Alpine dropped a support for it in 3.8 Highlights: - QEMU 8.0.4 - libgcc instead of musl Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

Bump up liburing and SEABIOS versions

729c4e2

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

rucoder force-pushed the rucoder/xen-4.18.0-rc4 branch from 79482da to 729c4e2 Compare October 31, 2023 15:56

rucoder changed the title ~~Bump up XEN version to 4.18.0-rc4~~ Bump up XEN version to 4.18.0 Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump up XEN version to 4.18.0 #3534

Bump up XEN version to 4.18.0 #3534

rucoder commented Oct 26, 2023 •

edited

deitch commented Oct 26, 2023

rucoder commented Oct 26, 2023

eriknordmark Oct 26, 2023

OhmSpectator Oct 27, 2023

OhmSpectator Oct 27, 2023

rene Oct 27, 2023

temerkhanov Feb 19, 2024

rene Oct 27, 2023 •

edited

rene Oct 27, 2023

rucoder Oct 27, 2023

christoph-zededa Oct 27, 2023

rene Oct 27, 2023

christoph-zededa Oct 27, 2023

rucoder commented Oct 27, 2023

OhmSpectator commented Oct 27, 2023

rucoder commented Oct 29, 2023

Bump up XEN version to 4.18.0 #3534

Are you sure you want to change the base?

Bump up XEN version to 4.18.0 #3534

Conversation

rucoder commented Oct 26, 2023 • edited

deitch commented Oct 26, 2023

rucoder commented Oct 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rene Oct 27, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rucoder commented Oct 27, 2023

OhmSpectator commented Oct 27, 2023

rucoder commented Oct 29, 2023

rucoder commented Oct 26, 2023 •

edited

rene Oct 27, 2023 •

edited