[DataStorage] Device Not found in Cache Issue

[nitu-s-gupta]

Signed-off-by: Nitu Sajjanlal Gupta nitu.gupta@samsung.com

Description

Bug: The edge-orchestration can not find the device in the cache if edge-orchestration registers device configuration to edgex for the first time. It works after reboot.

Solution: The configuration toml file is generated automatically, so the ip of edge-orchestration resolves the issue and callbacks are recieved.

Fixes #312

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

1. Clear redis database
2. Run the docker-compose up -d from deployments/datatsorage
3. Run edge-orchestration with datastorage service
4. Call an API in terms of uploading Int value

curl -X POST "{ip of edge-orchestration}:49986/api/v1/resource/int" -H "accept: text/plain" -H "Content-Type: text/plain" -d 123
For example:
curl -X POST "107.108.70.126:49986/api/v1/resource/int" -H "accept: text/plain" -H "Content-Type: text/plain" -d 123
The value gets uploaded successfully. which is verified with GET command

Test Configuration:

• Firmware version: Ubuntu 20.04
• Hardware: x86-64
• Edge Orchestration Release: 1.0.0

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[tiokim]

Thanks for the contribution!
Pleaset take a look at my comment.

[tiokim]

Host of Service in configuration.toml is empty with this PR.
Please refer to the log below.

$ docker exec -ti edge-orchestration /bin/bash
root@t25kim:/edge-orchestration# cat res/configuration.toml

[Clients]

  [Clients.Data]
    Host = "10.113.70.227"
    Port = 48080
    Protocol = "http"
    Timeout = 5000

  [Clients.Metadata]
    Host = "10.113.70.227"
    Port = 48081
    Protocol = "http"
    Timeout = 5000

[Device]
  DataTransform = true
  InitCmd = ""
  InitCmdArgs = ""
  MaxCmdOps = 128
  MaxCmdValueLen = 256
  ProfilesDir = "./res"
  RemoveCmd = ""
  RemoveCmdArgs = ""

[[DeviceList]]
  Description = "RESTful Device"
  Labels = ["rest","json"]
  Name = "edge-orchestration-c1b23cc6-0767-400a-9cf0-36e1b3902da2"
  Profile = "edge-orchestration-c1b23cc6-0767-400a-9cf0-36e1b3902da2"

  [DeviceList.Protocols]

    [DeviceList.Protocols.other]

[Registry]
  CheckInterval = "10s"
  FailLimit = 3
  FailWaitTime = 10
  Host = "10.113.70.227"
  Port = 8500
  Type = "consul"

[Service]
  AsyncBufferSize = 16
  ConnectionRetries = 20
  EnableAsyncReadings = true
  Host = ""
  Labels = []
  OpenMsg = "REST device started"
  Port = 49986
  Timeout = 5000

[Writable]
  LogLevel = "DEBUG"

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[tiokim]

LGTM Thanks for the contribution!

[MoonkiHong]

Seems good to me. Appreciate for your contribution to resolve the issue. 💯

[tdrozdovsky]

LGTM

[NiranjanPatil25]

okay

[NiranjanPatil25]

Pls add code comments briefing the rationale behind using values 16 , 20 , 10s etc ..for future maintainability

[suresh-lc]

LGTM, thanks for the quick fix before the release