Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing guide #352

Merged
merged 1 commit into from Aug 10, 2021
Merged

Update testing guide #352

merged 1 commit into from Aug 10, 2021

Conversation

tdrozdovsky
Copy link
Contributor

Signed-off-by: Taras Drozdovskyi t.drozdovsky@samsung.com

Description

Adds instructions on how to install the gocov package and staticckeck tool for testing the project.
Fixes #350

Type of change

  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tdrozdovsky tdrozdovsky added bug Something isn't working documentation Improvements or additions to documentation labels Aug 6, 2021
@tdrozdovsky tdrozdovsky self-assigned this Aug 6, 2021
@tdrozdovsky tdrozdovsky added this to In progress in Refactoring via automation Aug 6, 2021
tiokim
tiokim reviewed Aug 8, 2021
View reviewed changes
Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick contribution.
We also need an installation guide for gocov-html.

@tdrozdovsky
Update testing guide
7e22b01 
Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@tdrozdovsky
Copy link
Contributor Author

Thanks for quick contribution.
We also need an installation guide for gocov-html.

Thank you! Done!

@tdrozdovsky tdrozdovsky requested a review from tiokim August 9, 2021 07:37
tiokim
tiokim approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Refactoring automation moved this from In progress to Reviewer approved Aug 9, 2021
MoonkiHong
MoonkiHong approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@MoonkiHong MoonkiHong merged commit d8d4518 into lf-edge:master Aug 10, 2021
Refactoring automation moved this from Reviewer approved to Done Aug 10, 2021
@tdrozdovsky tdrozdovsky deleted the fix-test-policy branch September 1, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiokim tiokim tiokim approved these changes

@MoonkiHong MoonkiHong MoonkiHong approved these changes

@suresh-lc suresh-lc Awaiting requested review from suresh-lc

Assignees

@tdrozdovsky tdrozdovsky

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Refactoring
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing Guide Update
3 participants
@tdrozdovsky @tiokim @MoonkiHong