Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataStorage] Updating go.mod to avoid Crash #291

Merged
merged 1 commit into from Mar 28, 2021

Conversation

sun-sharma
Copy link
Contributor

  • Hanoi release of EdgeX had a problem with locks, due to which Home-Edge was crashing
  • Post Communication, a fork had been provided with fix
  • This would be removed post EdgeX Ireland release

Signed-off-by: Sunchit Sharma sun.sharma@samsung.com

Description

Post migration to Hanoi release for DataStorage, there was a crash notices when EdgeX servers were not running.
EdgeX has provided a temporary fork to solve this till the Ireland release. This has been incorporated in the go.mod

Fixes #231

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

-Code was build and run with the data storage files in the required folders :

  1. When the EdgeX servers were not running : No crash was seen.
  2. When EdgeX servers were running : System was properly able to connect.

Logs when server was not running

level=ERROR ts=2021-03-25T08:09:45.012262621Z app=datastorage source=init.go:154 msg="Get \"http://localhost:48080/api/v1/ping\": dial tcp 127.0.0.1:48080: connect: connection refused"
level=ERROR ts=2021-03-25T08:09:45.324791129Z app=datastorage source=init.go:139 msg="dependency Metadata service checking time out"
level=ERROR ts=2021-03-25T08:09:46.070120465Z app=datastorage source=init.go:139 msg="dependency Data service checking time out"
level=INFO ts=2021-03-25T08:09:46.129496244Z app=datastorage source=httpserver.go:116 msg="Web server shutting down"
level=INFO ts=2021-03-25T08:09:46.187623393Z app=datastorage source=httpserver.go:107 msg="Web server stopped"
level=INFO ts=2021-03-25T08:09:46.187639345Z app=datastorage source=httpserver.go:118 msg="Web server shut down"
INFO[2021-03-25T08:10:45Z]discovery.go:845 activeDiscovery [discoverymgr] activeDiscovery!!!            
INFO[2021-03-25T08:10:45Z]discovery.go:568 func1 [deviceDetectionRoutine] edge-orchestration-cf2bd64b-242a-46c2-85d9-ec8c8376ce7e 
INFO[2021-03-25T08:10:45Z]discovery.go:569 func1 [deviceDetectionRoutine] confInfo    : ExecType(container), Platform(docker) 
INFO[2021-03-25T08:10:45Z]discovery.go:570 func1 [deviceDetectionRoutine] netInfo     : IPv4([192.168.1.25]), RTT(0) 
INFO[2021-03-25T08:10:45Z]discovery.go:571 func1 [deviceDetectionRoutine] serviceInfo : Services([]) 

Test Configuration:

  • Firmware version: Ubuntu 18.04
  • Hardware: x86-64
  • Toolchain: Docker 20.10.1 , go 1.15.6
  • Edge Orchestration Release: Coconut

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- Hanoi release of edgeX had a problem with locks, due to which Home-Edge was crashing
- Post Communication, a fork had been provided with fix
- This would be removed post EdgeX Ireland release

Signed-off-by: Sunchit Sharma <sun.sharma@samsung.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tiokim tiokim added this to In progress in DataStorage via automation Mar 26, 2021
Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

DataStorage automation moved this from In progress to Reviewer approved Mar 28, 2021
@MoonkiHong MoonkiHong merged commit 4a19f28 into lf-edge:master Mar 28, 2021
DataStorage automation moved this from Reviewer approved to Done Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[DataStorage] Runtime error
4 participants