Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused assignment to local variable #133

Merged
merged 1 commit into from Sep 15, 2020

Conversation

tdrozdovsky
Copy link
Contributor

Signed-off-by: Taras Drozdovskyi t.drozdovsky@samsung.com

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #131

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Use https://lgtm.com/projects/g/lf-edge/edge-home-orchestration-go/ to check Active alerts.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As this PR resolves the reported issue that I raised from #131 .

Copy link
Contributor

@suresh-lc suresh-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title could have been softer like say : "Removed unused assignment to local variable".
Code changes wise looks fine.

@MoonkiHong MoonkiHong merged commit 618d89a into lf-edge:master Sep 15, 2020
@MoonkiHong MoonkiHong changed the title Fix useless assignment to local variable Removed unused assignment to local variable Sep 15, 2020
@MoonkiHong
Copy link
Contributor

@tdrozdovsky @suresh-lc Applied Suresh's comment.

@tdrozdovsky tdrozdovsky deleted the 131-fix-useless-variable branch December 14, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Do we need to rectify SecurityMgr? (Sensitive Data handling)
3 participants