Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to define custom context directory instead of '.' (is still default when omitted) #97

Merged
merged 2 commits into from Apr 16, 2024

Conversation

JimPanse81
Copy link
Contributor

In Version 1.18.0 there is no possibility to define a custom context directory. The context is appended hard coded as '.' at the end of the build command (method 'PodmanBuildCommand.build()'). Especially when copying files from the host into the image it is often necessary to expand the context to a higher directory.

This change adds the build configuration option "contextDir". If the option is ommited the fallback is still '.'

@lexemmens
Copy link
Owner

Hi @JimPanse81,

My apologies for the delay in response. I have been extremely busy in the past few months. I will review and merge your contributions this week.

Thanks again for your PR. It is greatly appreciated :-)

@lexemmens lexemmens merged commit 16225f6 into lexemmens:master Apr 16, 2024
2 checks passed
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants