-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a new method: pwn #61
base: master
Are you sure you want to change the base?
Conversation
if (typeof(angular) !== 'undefined') { | ||
angular.module('brototype', []).factory('Bro', function() { return Bro; }); | ||
if (typeof (angular) !== 'undefined') { | ||
angular.module('brototype', []).factory('Bro', function () { return Bro; }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long.
@@ -154,12 +154,24 @@ | |||
} | |||
// the deepest key is set to either an empty object or the value provided | |||
brobj[props[props.length - 1]] = value === undefined ? {} : value; | |||
}, | |||
"pwn": function (path) { | |||
const brobj = this.obj, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
@@ -154,12 +154,24 @@ | |||
} | |||
// the deepest key is set to either an empty object or the value provided | |||
brobj[props[props.length - 1]] = value === undefined ? {} : value; | |||
}, | |||
"pwn": function (path) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
var method = this.iCanHaz(methodString); | ||
return new Bromise(this.obj, method, arguments); | ||
}, | ||
"makeItHappen": function(key, value) { | ||
"makeItHappen": function (key, value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
var method = this.iCanHaz(methodString); | ||
return new Bromise(this.obj, method, arguments); | ||
}, | ||
|
||
"braceYourself": function(methodString) { | ||
"braceYourself": function (methodString) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
return this.obj !== void 0; | ||
}, | ||
|
||
"doYouEven": function(key, callback, options) { | ||
"doYouEven": function (key, callback, options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
@@ -48,11 +48,11 @@ | |||
Bro.NOWAY = false; | |||
|
|||
Bro.brototype = Bro.prototype = { | |||
"isThatEvenAThing": function() { | |||
"isThatEvenAThing": function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
} | ||
} | ||
return context; | ||
}, | ||
|
||
"hereComeTheErrors": function(callback) { | ||
"hereComeTheErrors": function (callback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
if (this.method instanceof Function) { | ||
var returnValue = this.method.apply(this.object, this.args); | ||
if (returnValue) { | ||
(callback || function(){}).call(context || this.object, returnValue); | ||
(callback || function () { }).call(context || this.object, returnValue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long.
@@ -10,21 +10,21 @@ | |||
} | |||
|
|||
Bromise.brototype = Bromise.prototype = { | |||
"butWhenIdo": function(callback, context) { | |||
"butWhenIdo": function (callback, context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
|
I'll fix them when I can. A bit busy now |
Fixes my own issue #60; Read that for more info