fixes #311 #315
Open
fixes #311 #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxlynxlynx
reviewed
Jul 4, 2018
| <View style={{ marginTop: 15 }}> | ||
| <Text style={styles.infoTitle}>{title.toUpperCase()}</Text> | ||
| <TouchableOpacity style={styles.infoTextWrapper} onPress={onPress}> | ||
| {icon && <Image source={icon} style={styles.image} resizeMode="contain"/>} | ||
| <Text style={styles.text}>{text}</Text> | ||
| {arrow && <Image source={arrow} style={styles.arrow} resizeMode="contain"/>} | ||
| {!!(counter || counter === 0) && |
There was a problem hiding this comment.
Can counter be non-numeric or why is this check needed?
There was a problem hiding this comment.
Zero value will be treated as falsy and React will try to render it outside of Text tag, which will cause an error.
There was a problem hiding this comment.
Sure, but the check allows any truthy value or zero, only excluding null and undefined. If those values are not possible, the whole check is redundant.
severianremi
reviewed
Jul 5, 2018
| } | ||
|
|
||
| render() { | ||
| const { teams, loading } = this.props; | ||
| const { teams, loading, isAuthenticated, isGuestSession } = this.props; | ||
| if (!isAuthenticated && isGuestSession) return this.renderGuestTeams(); |
There was a problem hiding this comment.
Please, add PropTypes for teams, loading, isAuthenticated, isGuestSession
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.