Fixes modifiers type signature in input_key callback #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the change itself is valid, but other consumers of the API still use the old signature (some tests, arcterm/tui-lua bindings) and yield build warnings or -worse-, bleed into next arg. |
Internally arcan uses uint16 for representing modifiers bitset, while this callback used to squeeze it into uint8.
cipharius
force-pushed
the
incorrect-tui-modifiers-type
branch
from
f8c2d8f
to
c35677c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally arcan uses uint16 for representing modifiers bitset, while this callback used to squeeze it into uint8.