Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make create_profile gracefully handle partial config objects #774

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

monperrus
Copy link

create_profile crashes when used as an API:

args = object()
...
create_profile(args):

this fix makes create_profile gracefully handle partial config objects

@guillaumevincent
Copy link
Member

hello, this is not the right python way to do this

create a default dict with default values, then update the args

args.update(default_args)

@monperrus
Copy link
Author

thanks for the feedback @guillaumevincent

updated the PR accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants