fix: nested packages detection #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmenko
commented
Apr 14, 2020
Comment on lines
+79
to
+84
| const fullFilePath = path.join(this.config.rootPath, filePath); | ||
| const matchingPackageFromPath = workspacePackages.find(packageInfo => { | ||
| return fullFilePath.startsWith(packageInfo.location); | ||
| }); | ||
| if (matchingPackageFromPath) return matchingPackageFromPath.name; | ||
| return ""; |
There was a problem hiding this comment.
This is the new logic to get the package name.
emmenko
commented
Apr 14, 2020
| @@ -20,9 +21,7 @@ export interface ConfigLoaderOptions { | |||
| } | |||
|
|
|||
| export function load(options: ConfigLoaderOptions = {}): Configuration { | |||
| let cwd = process.cwd(); | |||
| let rootPath = execa.sync("git", ["rev-parse", "--show-toplevel"], { cwd }).stdout; | |||
There was a problem hiding this comment.
Not really related to this PR, but I figured the git command belongs to the git file.
emmenko
commented
Apr 14, 2020
| @@ -5,7 +5,7 @@ exports[`createMarkdown multiple tags outputs correct changelog 1`] = ` | |||
| ## a-new-hope@4.0.0 (1977-05-25) | |||
|
|
|||
| #### :rocket: New Feature | |||
| * \`a-new-hope\` | |||
| * \`@star-wars/a-new-hope\` | |||
There was a problem hiding this comment.
The mock data contains scoped package names, hence these changes.
emmenko
commented
Apr 14, 2020
Comment on lines
+19
to
+33
| a0000003: ["packages/star-wars/a-new-hope/rebels.js"], | ||
| a0000004: ["packages/star-wars/a-new-hope/package.json"], | ||
| a0000005: ["packages/star-wars/empire-strikes-back/death-star.js"], | ||
| a0000006: ["packages/star-wars/empire-strikes-back/death-star.js"], | ||
| a0000007: ["packages/star-wars/empire-strikes-back/hoth.js"], | ||
| a0000008: ["packages/star-wars/empire-strikes-back/hoth.js"], | ||
| a0000009: ["packages/star-wars/empire-strikes-back/package.json"], | ||
| a0000010: ["packages/star-wars/return-of-the-jedi/jabba-the-hutt.js"], | ||
| a0000011: ["packages/star-wars/return-of-the-jedi/vader-luke.js"], | ||
| a0000012: ["packages/star-wars/return-of-the-jedi/leia.js"], | ||
| a0000013: ["packages/star-wars/return-of-the-jedi/package.json"], | ||
| a0000014: [ | ||
| "packages/star-wars/the-force-awakens/mission.js", | ||
| "packages/star-wars/origin-stories/rogue-one/mission.js", | ||
| ], |
There was a problem hiding this comment.
This is to ensure that the "nested" package locations work.
emmenko
commented
Apr 14, 2020
| @@ -106,45 +110,75 @@ const issuesCache = { | |||
| }, | |||
| }, | |||
| }; | |||
|
|
|||
| describe("multiple tags", () => { | |||
There was a problem hiding this comment.
Moved inside the describe("createMarkdown", for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the library assumes that packages are located under
packages/*and tries to derive the package name from the file path (seepackageFromPathmethod).This is fragile and it does not work anyway if packages are located in other directories or sub-directories.
This PR changes how package names are detected by implementing the
getPackagesmethod in the@lerna/projectpackage.I decided to copy over the important parts for a couple of reasons:
Now the packages are properly detected, based on the glob configuration in the yarn workspaces or
lerna.json.