type hints: mypy 1.8.0 clean #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
force-pushed
the
type_hints
branch
4 times, most recently
from
4c3d34f
to
c9fa058
Compare
Co-authored-by: Francis Charette Migneault <francis.charette.migneault@gmail.com>
|
The tests pass on my fork now :-) https://github.com/mr-c/mistune/actions/runs/7466055877/job/20316571986 @lepture Shall I add Python 3.12 to the test matrix and the package metadata, or would you rather that be in a different PR? |
fmigneault
added a commit
to fmigneault/schema_salad
that referenced
this pull request
Jan 9, 2024
This was referenced Jan 9, 2024
|
👍🏻 |
lepture
reviewed
Jan 17, 2024
| from .core import BlockState, InlineState, BaseRenderer | ||
| from typing import Any, Callable, Dict, Iterable, List, Optional, Tuple, Union | ||
|
|
||
| from typing_extensions import Literal |
There was a problem hiding this comment.
Python 3.7 doesn't have typing.Literal, that got introduced in Python 3.8
|
Thank you @lepture ! Can we get a new release of mistune so we can use these type hints and fixes in common-workflow-language/schema_salad#787 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Francis Charette Migneault @fmigneault
Closes: #329